Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve REDCapR's approach for catching & throwing errors --while providing useful context to the user #441

Open
wibeasley opened this issue Oct 8, 2022 · 0 comments
Assignees

Comments

@wibeasley
Copy link
Member

wibeasley commented Oct 8, 2022

A few years ago I changed how errors were thrown because I was worried about it revealing tokens or other secrets. But I went too far and too much is concealed. We'll switch to rlang's approach:

It may make sense to wait until moving to httr2 (#430), since hhtr2 will handle errors differently than httr:

HTTP errors are automatically converted into R errors. Use req_error() to override the defaults (which turn all 4xx and 5xx responses into errors) or to add additional details to the error message.

@wibeasley wibeasley self-assigned this Oct 8, 2022
wibeasley added a commit that referenced this issue Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant