Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API from Magpie-UI + unittests #67

Merged
merged 33 commits into from
Jun 26, 2018
Merged

API from Magpie-UI + unittests #67

merged 33 commits into from
Jun 26, 2018

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Jun 19, 2018

Changes

  • moved all API methods under /api directory, and Magpie-UI methods under /ui
  • regrouped common imports under 'definition' files
  • adds /magpie/__api__ for auto-generated API routes defined from within the code using function decorators
  • add /magpie/api route to view API specifications (swagger-ui)
    notes
    • module cornice_swagger used for decorators to populate __api__ should by itself provide a 'swagger-ui' interface, but it didn't seem to work when tested
    • used pyramid's framework to launch 2 apps serviced under /magpie, (Magpie + Swagger-UI)
  • add unittest setup with WebTest

[WIP]

  • transferring documentation of all routes (only basic ones done like /version)
  • add tests gradually with corresponding documentation transferred / validated
  • figure out how to /signin with WebTest (valid POST returns Unauthorized access when it shouldn't)

Other

includes PR #64
up on colibri

@fmigneault fmigneault requested a review from dbyrns June 19, 2018 20:15
@fmigneault fmigneault added the WIP label Jun 19, 2018
@fmigneault fmigneault changed the title API from API from Magpie-UI + unittests Jun 19, 2018
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants