environment, stylesheet, etc. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahclaude
reviewed
Mar 15, 2023
| @@ -150,10 +150,12 @@ def set_plot_attrs(attr_dict, xr_obj, ax): | |||
|
|
|||
| if 'ylabel' in attr_dict: | |||
| if 'yunits' in attr_dict and len(get_attributes(attr_dict['yunits'], xr_obj)) >= 1: # second condition avoids '[]' as label | |||
| ax.set_ylabel(get_attributes(attr_dict['ylabel'], xr_obj) + ' (' + | |||
| get_attributes(attr_dict['yunits'], xr_obj) + ')') | |||
| ylabel = wrap_text(get_attributes(attr_dict['ylabel'], xr_obj) + ' (' + | |||
There was a problem hiding this comment.
Wrap_text pourrait être ajouter à xlabel et title.
Les longueurs de strings pourraient être modifier en fonction de s'il s'agit du titre (timeseries vs gridmap), label, colorbar.
Sinon pour les titres il serait aussi possible d'utiliser textwrap (https://docs.python.org/3/library/textwrap.html)
| """ Return a list of the categorical colors associated with certain strings (SSP,RCP,CMIP).""" | ||
| path = Path(__file__).parents[1] / 'data/ipcc_colors/categorical_colors.json' | ||
| with open(path) as f: | ||
| cat = json.load(f) |
There was a problem hiding this comment.
Est-ce que les couleurs associées aux modèles (CanESM5, MPI,...) sont dans le json?
| ytick.color : k | ||
|
|
||
| ### FIGURE | ||
| figure.figsize : 8, 6 # default |
There was a problem hiding this comment.
Pourrait être dans une autre stylesheet pour avoir une version notebook, article ou présentation.
sarahclaude
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified environment.yml, added stylesheet, added func to show list of categorical colors, improved checks in timeseries()