Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stripes fct #56

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Add stripes fct #56

merged 8 commits into from
Apr 17, 2023

Conversation

Beauprel
Copy link
Contributor

Added climate stripes function, without some of the stylistic elements dividing the historical and future periods (tbd).
Minor bug fixes in other functions.

@Beauprel Beauprel self-assigned this Apr 12, 2023
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait un exemple dans le notebook!

spirograph/matplotlib/plot.py Show resolved Hide resolved
spirograph/matplotlib/plot.py Outdated Show resolved Hide resolved
spirograph/matplotlib/plot.py Show resolved Hide resolved
Copy link
Collaborator

@sarahclaude sarahclaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function doesn't work with a DataArray. It gives back a blank figure with only the time axis and colorbar.
Otherwise, it looks good!

Conflicts:
	spirograph/matplotlib/__init__.py
	spirograph/matplotlib/plot.py
@Beauprel
Copy link
Contributor Author

Made a few changes:

  • added docs
  • fixed bugs (DataArray not working, matplotlib colormaps not showing)
  • added format check for ssp, rcp (rcp45 -> RCP4.5)

Tested more thoroughly, everything seems to be working fine.

Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! J'écrirais juste les ssp un peu plus gros.

@Beauprel Beauprel merged commit a9fd966 into main Apr 17, 2023
@Beauprel Beauprel deleted the stripes_1 branch April 17, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants