Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output updates to correspond with Finch version 0.11.3 #328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mishaschwartz
Copy link
Collaborator

The tests for the pull request here: bird-house/birdhouse-deploy#354 are failing because the description of the following processes from the Finch WPS have changed slightly:

  • subset_bbox
  • heat_wave_frequency
  • subset_gridpoint

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tlvu
Copy link
Contributor

tlvu commented May 23, 2024

Oh right, this Finch update ! @Zeitsperre Are we still going with this Finch or you're planning a newer Finch to contain the newer Xclim?

@mishaschwartz Thanks for refreshing the notebook output ! Do not merge this PR until the new Finch is live on PAVICS.

FYI, we usually will take care to match both notebook and corresponding bird when the bird goes live so our nightly Jenkins and the Jenkins in CRIM github pipeline is not broken. We usually delay refreshing the notebook until we know for sure the version of the bird that will go-live.

Another example of synchronizing notebook update is when a new Jupyter env goes live, example here Ouranosinc/PAVICS-e2e-workflow-tests#121, look at the section "Matching notebook fixes".

@mishaschwartz
Copy link
Collaborator Author

I'm just trying to help out. I was recently added as a reviewer on the bird-house/birdhouse-deploy#354 PR which seems to have stalled for a while.

Feel free to close this if you have a better process for updating notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants