Add specific_humidity_from_dewpoint
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
approved these changes
Feb 23, 2022
| """ | ||
|
|
||
| ε = 0.6219569 # weight of water vs dry air [] | ||
| e = saturation_vapor_pressure(tas=tdps, method=method) # vapor pressure [Pa] |
There was a problem hiding this comment.
Is there a reason the ice_thresh arg of e_sat is not implemented?
There was a problem hiding this comment.
From what I read, this is only useful below -40C, so it seemed overkill here. But I may have misunderstood.
There was a problem hiding this comment.
Oh! I didn't know that. I added it in the others for completeness and thought it could be here too for symmetry...
There was a problem hiding this comment.
I'm sympathetic to the symmetry argument, but I didn't want to add a parameter I was not sure would ever be used. I don't have a strong opinion, and we don't even have a real use case now that "ps" is required...
RondeauG
approved these changes
Feb 23, 2022
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.bumpversion patchhas been called on this branch.zenodo.jsonWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information:
long_nameis capitalized for humidity indicators (long_name="Specific Humidity"). Is that a typo ?invalid_valuesstuff cause I wasn't sure if it applied here.