-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python3.12 #1613
Merged
Merged
Support Python3.12 #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On inspection, the No further action is required. |
5 tasks
aulemahal
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Zeitsperre
commented
Jan 22, 2024
Zeitsperre
added a commit
that referenced
this pull request
Jan 29, 2024
### What kind of change does this PR introduce? * Drops Python3.8 references and marks Python3.9 as base requirement. * Drops older `xarray` and `pandas` support. * Updates documentation and CI for dropped Python3.8. * Raises required versions of `scipy` and `numpy` (`1.9.0` and `1.20.0`, respectively). * Removes the `winter_storm` indice and indicator (deprecated in `xclim` v0.46.0). * Adopts the new syntax for frequency codes: - "A" is no more - Y -> YE, Q -> QE, M -> ME - H -> h, T -> min, S -> s, L -> ms, U -> us, N -> ns * Addresses several `DeprecationWarning` and `RuntimeWarning` messages related to `numpy`, `xarray`, and `pint` ### Does this PR introduce a breaking change? **Yes**, Python3.8 is no longer supported and base dependency versions have been augmented: - `numpy>=1.20.0` - `pandas>=2.2.0` - `scipy>=1.9.0` - `xarray>=2023.11.0` ### Other information: ~Python3.12 support is still not possible due to missing Python3.12 builds for `numba`. (This is being addressed in #1613)~ - This has been addressed. A Pull Request has been opened to address `DeprecationWarning`s stemming from `numpy` calls in `eofs` (ajdawson/eofs#148; `eofs` has been removed due to licensing-related issues (#1621))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
numba
release candidate repository to theenvironment.yml
.main.yml
workflows to test for dependency resolution.Does this PR introduce a breaking change?
No.
Other information:
xclim
running under Python3.12 with numba v0.59.0rc1 is testing without issues locally.See: numba/numba#9197