Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4580: Make the bot commits signed #379

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

rugoncalves
Copy link
Contributor

This PR is changes the github workflows so that all manual commits are signed.

What was happening

  • The commits performed by the bot, were not signed
  • The commits will now be blocked if not signed

What was done

  • Create helper Git actions that will work as an abstraction layer once we start
    • manual-git-commit runs the required git commands to perform a commit.
    • setup-gpg sets the git to be able to sign the commits, with the gpg
    • signed-gpg-commit invokes the two actions above, for simplicity in the workflow, and creating an abstractions so that in the future, we can replace the external action being used by another, without having to change the workflow
  • Added the workflows to:
    • Run lint and compile the code on PR to dev
    • Generate the documentation when a push occurs to main

Test Steps

  1. Perform a PR to dev
  2. Accept the PR

Checklist

  • tested on a fork
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Oct 24, 2023
joselrio
joselrio previously approved these changes Oct 24, 2023
BenOsodrac
BenOsodrac previously approved these changes Oct 24, 2023
@rugoncalves rugoncalves dismissed stale reviews from BenOsodrac and joselrio via 0730225 October 24, 2023 13:18
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gnbm gnbm requested a review from BenOsodrac October 26, 2023 09:38
@rugoncalves rugoncalves merged commit b23d8f4 into dev Oct 26, 2023
12 checks passed
@rugoncalves rugoncalves deleted the ROU-4580-SIGN-COMMITS branch October 26, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants