forked from quisquous/cactbot
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: Initial r2n triggers/timeline #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
💬ko
💬cn
raidboss
/ui/raidboss module
💬de
💬fr
needs-review
Awaiting review
labels
Jul 16, 2024
45 tasks
JLGarber
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting that together. I don't have time tonight to test it in-game myself, but I think we can implement it as a first pass and fix it up as we go.
wexxlee
reviewed
Jul 18, 2024
I know that if the OP option to end encounter when out of combat is
enabled, that will reset the entire raidboss module. But I don't know if
there's a check for e.g. the InCombat line somewhere.
…On Wed, Jul 17, 2024, 22:57 Wexx ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ui/raidboss/data/07-dt/raid/r2n.txt
<#243 (comment)>
:
>
hideall "--Reset--"
hideall "--sync--"
-0.0 "--Reset--" ActorControl { command: "4000000F" } window 0,100000 jump 0
I'm not 100% sure off the top of my head. I copy/pasted the timeline from
the make_timeline tool initially, apparently that doesn't include the
reset. If it's still required, I guess it's a bug in make_timeline too?
@JLGarber <https://github.com/JLGarber> - do you know whether an
affirmative Reset line is still required? As for make_timeline, I'm not
positive, but I suspect the reason it's not included in the default output
is because it wouldn't apply, e.g., to dungeon content or other content
that uses seals/unseals instead of ActorControl wipes. Still, to your
point, make_timeline should be able to detect if that's the case and add
it (if it is, in fact, required).
—
Reply to this email directly, view it on GitHub
<#243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOWBLRN2G2CGGTN5Z7NJPDZM4VLBAVCNFSM6AAAAABK7EXMO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBUGUYDCNZTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included headmarker info for future savage comparison.
Loop needs verified still.
Stack/Spread/tank lines/light party stacks might be better triggered off of headmarkers, felt like the cast ability was slightly slower than headmarker.
stacks
outputStrings value was copy/pasted from another trigger set, might be better to only include theen
value and let translators handle the others.