Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: Initial r2n triggers/timeline #243

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

valarnin
Copy link
Collaborator

I included headmarker info for future savage comparison.

Loop needs verified still.

Stack/Spread/tank lines/light party stacks might be better triggered off of headmarkers, felt like the cast ability was slightly slower than headmarker.

stacks outputStrings value was copy/pasted from another trigger set, might be better to only include the en value and let translators handle the others.

Copy link
Collaborator

@JLGarber JLGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting that together. I don't have time tonight to test it in-game myself, but I think we can implement it as a first pass and fix it up as we go.

ui/raidboss/data/07-dt/raid/r2n.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the needs-review Awaiting review label Jul 17, 2024
@valarnin
Copy link
Collaborator Author

valarnin commented Jul 18, 2024 via email

@valarnin valarnin merged commit 433133b into OverlayPlugin:main Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants