-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove the use of mix-type fields for transportation access restrictions #85
feat: remove the use of mix-type fields for transportation access restrictions #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to discuss alternative names for accessType
.
counterexamples/transportation/segment/road/restrictions/bad-access-mode-not.yaml
Outdated
Show resolved
Hide resolved
The merge-base changed after approval.
@bastiaanvanassche-tomtom Is it fair to say this PR captured what we wanted to do, but we never managed to merge it? |
Can we change |
Plan agreed in the 2024-02-20 transportation TF main business meeting:
|
e9c821a
to
ef4cd28
Compare
ef4cd28
to
ee1d56c
Compare
These TODOs are now tracked in https://github.com/OvertureMaps/tf-transportation/issues/101. So we really want to push to get this one reviewed and merged as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
._a
|8P
__| __
.-------, w
\ . / w
)a:f( .
/_ \ |
(___2___) `. _ ,'
.c@a. _______ ( )._______
~ `Y888P ~ ~-
~~~~ ~ ~~ =-
Based on:
this PR tackles the use of mix-type fields for transportation access restrictions