-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting files for buildings theme #89
Conversation
6fa7953
to
5ce074e
Compare
5ce074e
to
5c5909a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukaszMichalski-TomTom I realize these aren't all your doing, but can you make all the Overture values camelCased?
It's the standard (even though I don't love it).
@LukaszMichalski-TomTom Just so I understand... facadeMaterial describes the mapping for
|
task-force-docs/buildings/overture_roofMaterial_OSM_mapping.json
Outdated
Show resolved
Hide resolved
task-force-docs/buildings/overture_facadeMeterial_OSM_mapping.json
Outdated
Show resolved
Hide resolved
I will add README next to mapping files to describe osm tag that need to be used.
|
5c5909a
to
91df02b
Compare
Reminder: @jwass took the action to consult with the PR authors and determine if this can be brought back to life. |
task-force-docs/buildings/overture_facadeMeterial_OSM_mapping.json
Outdated
Show resolved
Hide resolved
task-force-docs/buildings/overture_facadeMaterial_OSM_mapping.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please:
- Fix
facedMaterial
tofacadeMaterial
? (typo in theREADME.md
) - Ensure the files end in a newline (should not have the no newline at EOF icon at the bottom of every diff)
75f724c
91df02b
to
75f724c
Compare
410298a
to
b7c02c3
Compare
@LukaszMichalski-TomTom I updated these to be These are out-of-sync with the current logic in the buildings airflow pipeline and schema, which is causing hundreds of thousands of validation errors, which will soon cause the theme to fail promotion. Can you confirm that these are the correct mappings (see the table below), then we can make sure that the pipeline and schema files are up-to-date? |
Based on the current logic in the mapping JSON file (https://github.com/OvertureMaps/schema/pull/89/files#diff-5e18ae5feffd2d58657bf46be190bc986fb510fc7ee3b69f0e2d185828f4fad1), here are the counts for thee entire building theme:
|
I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) ) /\
===== / \
_|___|_____/ __ \____________
|::::::::::/ | | \:::::::::::|
|:::::::::/ ==== \::::::::::|
|::::::::/__________\:::::::::|
|_________| ____ |__________|
| ______ | / || \ | _______ |
|| | || ====== || | ||
||--+---|| | | ||---+---||
||__|___|| | o| ||___|___||
|========| |____| |=========|
(^^-^^^^^-|________|-^^^--^^^)
(,, , ,, ,/________\,,,, ,, ,)
','',,,,' /__________\,,,',',;;
Feb 22, 2024: This PR has been resurrected and re-based, scroll to bottom for context
Added mapping files for OSM values to Overture enumeration values.
Additional values:
facadeMaterial:
roofMaterial
roofShape:
Four roof shape names changed to OSM equivalents, e.g.
gable
→gabled
. I did it to make it more in line with OSM tooling and possible renders that can generate roof geometry based on this value. If someone would like to use Overture data to generate visualization, it may be easier for them.