Comment viewer #94
Merged
Comment viewer #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Branch was made from #87 so that's a blocker until it's merged into master. It's became an ad-hoc dev branch for the next week or so until this issue (and other debt issues) are solved. |
|
Done with pagination to 50 top-level comments per. Replies are automatically expanded, it's too much work to have an expansion option here right now, when #86 this will be a lot easier to do. For now, nice comment archiving and a simple viewer has been implemented, with archiving having enough detail to be used down the road. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds comment viewing to fufill the original #50 issue for Yark 1.3. Comment archiving has already been added, but this adds comments to the viewer.