Improve file saving and its corresponding tests #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it selectable via 'pytest -k output_data_format'
Note to self: 'pytest --disable-recording' will perform tests **without** VCR functionality, so you can run it to see if the tests pass and it's the time to re-record the cassettes to match up with the now-successful tests.
Milind220
reviewed
Apr 25, 2022
| @@ -91,7 +91,8 @@ def __init__( | |||
|
|
|||
| if self.file_name == "air_quality": | |||
| warnings.warn( | |||
| "You have not specified a custom save file name. Existing files with the same name may be overwritten!" | |||
| "You have not specified a custom save file name. " | |||
There was a problem hiding this comment.
Ahhh yes the cause of that annoying linter check fail
There was a problem hiding this comment.
Black is not able to fix that for us, apparently.
Milind220
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.