Introduces an error state for threading failures. Fixes #64. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fill_memory_blocks() configured to return a status, this introduces checks for a number of a different error conditions, inlcuding calloc() and NULL pointer failures. These were previously ignored errors. Thread failures no longer call printf/exit, ensuring better support for higher level bindings. fill_memory_blocks() is only called in one place, it's return value is now checked. Implications for bindings: new error code may need dedicated handling. This patch can be tested by setting ulimit -u and running ./argon2 with a relevant thread count.
veorq
added a commit
that referenced
this pull request
Jan 12, 2016
Introduces an error state for threading failures. Fixes #64.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill_memory_blocks() configured to return a status, this introduces checks
for a number of a different error conditions, inlcuding calloc() and NULL
pointer failures. These were previously ignored errors.
Thread failures no longer call printf/exit, ensuring better support for
higher level bindings. fill_memory_blocks() is only called in one place,
it's return value is now checked.
Implications for bindings: new error code may need dedicated handling.
This patch can be tested by setting ulimit -u and running ./argon2 with a
relevant thread count.