Bug fixes #5
Merged
Bug fixes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explained by me on Discord, 20 February 2020: "Found a bug that causes characters to load slower based on the number of items in their inventory. Every item causes a query to be executed in the db. On my local machine, the specific section of code is now ~40ms faster when loading 1 character full of items. Here is what I'm referring to: "AND petid IS NOT NULL" should be "AND petid > 0" or something similar Basically, the petid field is not a boolean. The check will always pass since -1 is not null, and the number -1 is used to indicate if the item is a pet or not."
P0nk
pushed a commit
that referenced
this pull request
Aug 11, 2022
Clean up code & Upgrading syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix previously reported bugs in HeavenMS.