Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename export files and folders #223

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Conversation

jamesrweb
Copy link
Collaborator

Fixes #222 (See notes).

Proposed Changes

  • To support all possible export bundle types we should export the main, module and browser fields from the package.json.

Additional Notes (optional)

It fixes it kind of but not really since it only "helps" nextjs' webpack implementation to understand more about the module structure but it still doesn't fix the underlying issue on their end.

To support all possible export bundle types we should export the main, module and browser fields from the package.json.
@jamesrweb jamesrweb added enhancement dependencies Pull requests that update a dependency file documentation Pull requests that update project documentation labels Jan 27, 2023
@jamesrweb jamesrweb requested a review from a team January 27, 2023 00:26
@jamesrweb jamesrweb self-assigned this Jan 27, 2023
@jamesrweb jamesrweb requested review from yevdyko and removed request for a team January 27, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Pull requests that update project documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextjs internal issue
1 participant