Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the batching logic from Model to BatchedModel. #1246

Merged
merged 0 commits into from
Aug 11, 2023
Merged

Move the batching logic from Model to BatchedModel. #1246

merged 0 commits into from
Aug 11, 2023

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Aug 8, 2023 •
edited
Loading

Move the batching logic from Model to BatchedModel.

The Model class will keep an abstract predict method, and both BatchedModel and BatchedRemoteModel will implement predict but require their subclasses to implement predict_minibatch.

@copybara-service copybara-service bot changed the title Move the batching logic from Model to BatchedModel. Move the batching logic from Model to BatchedModel. Aug 9, 2023
@copybara-service copybara-service bot force-pushed the test_554875762 branch 4 times, most recently from 6a76df4 to fc7fc2e Compare August 11, 2023 16:25
@copybara-service copybara-service bot closed this Aug 11, 2023
@copybara-service copybara-service bot merged commit 6fdcbfe into dev Aug 11, 2023
@copybara-service copybara-service bot deleted the test_554875762 branch August 11, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants