-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update saliency methods to use a framework-agnostic "core" subpackage, and moves all TF1 functionality to an optional "tf1" subpackage. #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Ben, it looks great! I left some minor comments.
Could you also please update the PR title and description to list major updates that are happening. The title could be about making the library framework agnostic, and you could list the changes in the features or bugs this fixes the description as well as how you tested (e.g. ran notebooks visually compared and ran method tests). Thank you
Looks good, could you update the PR description and title please? |
This also resolves #16. We may want to think about adding more notebook examples for other frameworks in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the description that you no longer use tf.lite models and use tf hub for tf1 and keras for the core notebooks, respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes in this PR:
Bugfixes:
Tests for this change: