Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 #47

Merged
merged 34 commits into from
Aug 16, 2020
Merged

Version 2 #47

merged 34 commits into from
Aug 16, 2020

Conversation

PBug90
Copy link
Owner

@PBug90 PBug90 commented Feb 9, 2020

Version 2 of the parser:

  • async replay parsing interface
  • code refactoring, better typescript utilization (get rid of "any" usage). This includes a customized Buffer parser with proper Typescript Types because binary-parser types feel extremely clunky
  • toolchain updates
  • sample parser output
  • clear usage documentation
  • better parser error debugging utilities (implemented by getting rid of binary-parser dependency)

@PBug90 PBug90 changed the title feat: async replay parser interface Version 2 May 19, 2020
@PBug90 PBug90 marked this pull request as ready for review May 20, 2020 16:58
@codeclimate
Copy link

codeclimate bot commented Aug 16, 2020

Code Climate has analyzed commit c78a709 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 97.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.4% (0.9% change).

View more on Code Climate.

@PBug90 PBug90 merged commit 4eedbff into master Aug 16, 2020
@PBug90 PBug90 deleted the async-replay-parser branch August 16, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant