Added temporary fix for build error #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis build failed confirming what I suspected, that it would fail to build on linux machines. Not sure what action to go from here as it fixes some builds on windows but breaks other builds? |
|
This fix should be temporary until JavaFX 13 is released which is a permanent fix. |
|
almost there. mind adding a comment linking to the upstream bug (or at least back to this comment) so when JavaFX 13 comes out we'll know to remove it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add
System.load("C:\\Windows\\System32\\WindowsCodecs.dll");to 2 of the tests as a temporary fix to javafxports/openjdk-jfx#66. This was causinggradlewbuilds to fail on my side withEXCEPTION_ACCESS_VIOLATIONduring runningTask :test.This commit need to be tested on linux and mac machines as it could cause builds to fail on them.