Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 351 half levels #356

Merged
merged 28 commits into from
Jun 20, 2018
Merged

Issue 351 half levels #356

merged 28 commits into from
Jun 20, 2018

Conversation

doutriaux1
Copy link
Collaborator

No description provided.

@doutriaux1
Copy link
Collaborator Author

@durack1 @taylor13 i need your approval on tables first.

@@ -1186,7 +1186,7 @@
},
"dissi14c": {
"frequency": "mon",
"modeling_realm": "ocnBgChem",
"modeling_realm": "ocnbgchem",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 eek, nope this should be ocnBgchem - so the only upper case is B

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@durack1 @taylor13 I thought it was supposed to be all lower case. My bad, will push an update right away

@doutriaux1
Copy link
Collaborator Author

@durack1 is that ok now?

"fddtalk": {
"frequency": "mon",
"modeling_realm": "ocnBgChem",
"modeling_realm": "ocnBgchem",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 perfect ocnBgchem

@taylor13

@doutriaux1 doutriaux1 merged commit 00fb6d2 into master Jun 20, 2018
@doutriaux1 doutriaux1 deleted the issue_351_half_levels branch June 20, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants