Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precip variability and distribution to docs #966

Merged
merged 32 commits into from
Nov 30, 2023
Merged

Add precip variability and distribution to docs #966

merged 32 commits into from
Nov 30, 2023

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented Jul 28, 2023 •
edited
Loading

This is a draft of a page for the precipitation variability metrics on our GitHub.io site.

TODO

  • Squash commits
  • Add overview to precip distribution
  • Add submitted paper to precip distribution as reference?

Address #965

Ana Ordonez added 21 commits January 13, 2021 15:06
add version
238dab7
Merge branch 'master' of https://github.com/PCMDI/pcmdi_metrics
7c4d089
resolve conflicts
a708613
Merge branch 'master' of https://github.com/PCMDI/pcmdi_metrics
2505ed1
Merge branch 'master' of https://github.com/PCMDI/pcmdi_metrics
fa3d8f7
Merge branch 'master' of https://github.com/PCMDI/pcmdi_metrics
718e4e9
Merge branch 'master' of https://github.com/PCMDI/pcmdi_metrics
8d829f7
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
1232d0d
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
74f1380
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
1517414
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
3dc0c54
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
cd5c94e
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
9b54465
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
803fbe1
add page
ccf8095
fix formatting
54248bf
fix formatting
4198e46
fix formatting
e14aa15
add link
dddc7c2
fix link
ec83ae9
add title
8e68247
@acordonez acordonez changed the title Add page for precip variability to docs Add precip variability and distribution to docs Jul 29, 2023
@lee1043 lee1043 added the doc label Aug 30, 2023
@lee1043
Copy link
Contributor

lee1043 commented Sep 18, 2023

@acordonez this looks good to me, please feel free to merge it.

@lee1043
Copy link
Contributor

lee1043 commented Nov 30, 2023

@acordonez can this be merged?

@acordonez
Copy link
Collaborator Author

I'm missing some overview text and a reference for the Precip Distribution page, but if we're fine skipping that for now then I'm ok with merging.

@lee1043
Update metrics_precip-distribution.rst
11abb82 
Add overview text and reference paper
@lee1043
Update metrics_precip-distribution.rst
38c89a3 
Add placeholder for demo notebook
@lee1043
Copy link
Contributor

lee1043 commented Nov 30, 2023

@acordonez thank you for clarifying. I added an overview text, reference paper, and a placeholder for demo for precip distribution.

@lee1043
Copy link
Contributor

lee1043 commented Nov 30, 2023

@acordonez please feel free to merge it.

@acordonez acordonez marked this pull request as ready for review November 30, 2023 17:30
@acordonez
Copy link
Collaborator Author

@lee1043 Thank you for adding those, I'll merge this

@acordonez acordonez merged commit 03bee12 into main Nov 30, 2023
5 checks passed
@acordonez acordonez deleted the ao_965_update_docs branch November 30, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee1043 lee1043 lee1043 approved these changes

@gleckler1 gleckler1 Awaiting requested review from gleckler1

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acordonez @lee1043