GameDB: Patch to fix Valkyrie Profile 2 PAL FMV timing

[refractionpcsx2]

Description of Changes

Patch to sync audio and video in Valkyrie Profile 2 FMV's

Rationale behind Changes

I'm not sure on the source of this but, I suspect the game thinks somewhere that it's in NTSC mode instead of PAL (I think a few games do this), but I'm unsure where this would be. This patch will suffice for the moment, until somebody completely dissects this game.

Suggested Testing Steps

Test Valkyrie Profile 2 PAL FMV's

[Goatman13]

I think this patch can trigger anti-cheat mechanic (Gameguard) and break people game saves. This is irreversible, broken saves cannot be recovered. Protection is really nasty and trigger after few chapters, there is no way to tell if it's already broken or not.

[refractionpcsx2]

Ugh really?? Wow what a dumb thing to put in a single player game....

I guess I'll remove it again then...

[Goatman13]

Yeah, a lot of hassle to prevent cheats in single player game. As far as i know game scan code, and do some arithmetic operations on it to detect changes. Pnach file here have more info: https://forums.pcsx2.net/Thread-Post-your-PCSX2-cheats-patches-here?pid=595942#pid595942

[refractionpcsx2]

Good lord, that's a chonky patch... Sounds like they do a bunch of scary checks, but mostly to avoid ridiculous values? I'm not sure they'd go through the effort to check the fmv code all, but much cheating you can do the, but better to be safe than sorry I guess. Maybe somebody should play the game with the fix first, who is willing to be a sacrificial lamb, so to speak

[Goatman13]

"Sounds like they do a bunch of scary checks, but mostly to avoid ridiculous values?"
I think TriAce overdid it to whole code segment. I know codes like remove post processing triggered that protection.

[refractionpcsx2]

bonkers lol.

Well Technostrophe on the discord is going to check the patch with a sacrificial run, see if it's viable.

[refractionpcsx2]

looks like the intro (ingame cutscene) crashes half way through if you're in 16:9 with the patch.

I guess that's that then.

Edit: Looks like a forced lockup, if I remove this beq, it continues to work

found another one

[Goatman13]

Yup that's what game protection do apparently.

[refractionpcsx2]

yeah, I mean in theory we could go through all the code and kill all these loops.

is it possible this is how it kills peoples saves, by hanging in the middle?

in theory we could use our dynamic patching to catch these patterns and nop them out on the fly

[Goatman13]

There is "save corruptor" function that rigger at some condition. To be honest if you really need it fixed just do it outside of EE memory. Like i don't know, in recompiler or something.

[refractionpcsx2]

Well we don't have any code in there to do it for that and I'm loathed to hack it in to the JIT just for one game. even the Dynapatch stuff will edit the memory as well, this will only be saved if the game then overwrites this again when the next scene is loaded.