Updater:Mac: Show tar stderr if it fails #10227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TellowKrinkle
force-pushed
the
MacUpdaterErrorReporting
branch
from
dd1bf76
to
43c78ed
Compare
stenzek
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Prints stderr from tar command if it fails
Rationale behind Changes
User came to us with the updater failing due to being unable to unpack the update, maybe seeing the stderr from tar will help
Suggested Testing Steps
Untested, but it hopefully won't be worse than the current error message
(If anyone can think of a way to make tar fail while creating the staging directory succeeds, please test that)