Debugger: Don't modify disassembly focus on CPU state change #10406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrlinkwii
approved these changes
Dec 15, 2023
Daniel-McCarthy
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Changes look good, nice work figuring out these issue!
I tested:
- Verifying the breakpoint bug is no longer an issue. I am no longer able to reproduce it with your changes.
- Verifying that removing a result from the search list still works as expected. No impact on functionality.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #10392
Rationale behind Changes
The inactive CPU widget was being set to focus every time the VM state changed to pause.
Suggested Testing Steps
Try to reproduce the issue in #10392
I also fixed a signed-compare warning. Try removing memory search results and verify that it works.