SaveState: Various Improvements #11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
changed the title
kamfretoz
force-pushed
the
SaveYourState
branch
4 times, most recently
from
e5e91f8
to
390c33b
Compare
|
Now ready for review and testing. |
kamfretoz
force-pushed
the
SaveYourState
branch
from
3059608
to
f555792
Compare
AmyRoxwell
approved these changes
Sep 27, 2024
JordanTheToaster
approved these changes
Sep 28, 2024
F0bes
requested changes
Sep 28, 2024
kamfretoz
force-pushed
the
SaveYourState
branch
from
f555792
to
f1db14b
Compare
kamfretoz
force-pushed
the
SaveYourState
branch
2 times, most recently
from
0badfe8
to
9f76873
Compare
kamfretoz
force-pushed
the
SaveYourState
branch
from
9f76873
to
a651e2d
Compare
|
Fobes has recommended a much better and simpler solution, now opening the pause menu will first check if the savestate selector is open and if so, will close it. The default open timeout is still lowered to 5s. |
kamfretoz
changed the title
kamfretoz
force-pushed
the
SaveYourState
branch
from
a651e2d
to
2f940f0
Compare
JordanTheToaster
approved these changes
Sep 30, 2024
F0bes
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR adds an option that allows you to configure both the compression type and also the level for savestate.
Preview:
Also updates the base FSUI translation and the glyph ranges.
Rationale behind Changes
QoL Improvements and freedom of choices.
Suggested Testing Steps
Test if the savestate are compressed and can be loaded correctly.