PCSX2: "FMV Aspect Ratio Switch/Override" feature #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightningterror
force-pushed
the
lightning-fmvaspectratio-flatoutorigin
branch
from
78705da
to
e1af8f9
Compare
arcum42
approved these changes
Nov 18, 2018
turtleli
reviewed
Nov 18, 2018
lightningterror
force-pushed
the
lightning-fmvaspectratio-flatoutorigin
branch
2 times, most recently
from
44c29cc
to
92d9570
Compare
lightningterror
commented
Nov 18, 2018
lightningterror
force-pushed
the
lightning-fmvaspectratio-flatoutorigin
branch
from
92d9570
to
6abe797
Compare
lightningterror
changed the title
Change "Switch to 4:3 aspect ratio when an FMV plays" to "FMV Aspect Ratio Override" drop down menu. The option temporarily changes the Aspect Ratio to either 16:9 or 4:3 depending on the option that is selected, and depending on the Window Aspect ratio that is selected. Original commit: 8d471e1 Co author: lightningterror.
lightningterror
force-pushed
the
lightning-fmvaspectratio-flatoutorigin
branch
from
6abe797
to
0482f1d
Compare
turtleli
reviewed
Nov 18, 2018
lightningterror
added a commit
that referenced
this pull request
Nov 18, 2018
Small follow up correction from #2690, the ini options were inverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the commit a bit, also adjusted that the option works on 4:3 Window Aspect ratio as well.
Change "Switch to 4:3 aspect ratio when an FMV plays" to
"FMV Aspect Ratio Override" drop down menu.
The option temporarily changes the Aspect Ratio to either
16:9 or 4:3 depending on the option that is selected,
and depending on the Window Aspect ratio that is selected.
Original commit:
8d471e1
Original PR:
#1918
Co author: lightningterror.
Anyone is free to make any desired changes so we can get this up and running on master branch.
Close #2114