Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCSX2: "FMV Aspect Ratio Switch/Override" feature #2690

Merged
merged 1 commit into from Nov 18, 2018

Conversation

Projects
None yet
4 participants
@lightningterror
Copy link
Member

commented Nov 17, 2018

Cleaned up the commit a bit, also adjusted that the option works on 4:3 Window Aspect ratio as well.

Change "Switch to 4:3 aspect ratio when an FMV plays" to
"FMV Aspect Ratio Override" drop down menu.

The option temporarily changes the Aspect Ratio to either
16:9 or 4:3 depending on the option that is selected,
and depending on the Window Aspect ratio that is selected.

Original commit:
8d471e1
Original PR:
#1918

Co author: lightningterror.

Anyone is free to make any desired changes so we can get this up and running on master branch.

Close #2114

@lightningterror lightningterror force-pushed the lightning-fmvaspectratio-flatoutorigin branch from 78705da to e1af8f9 Nov 17, 2018

@arcum42 arcum42 self-requested a review Nov 18, 2018

Show resolved Hide resolved pcsx2/gui/AppConfig.cpp Outdated

@lightningterror lightningterror force-pushed the lightning-fmvaspectratio-flatoutorigin branch 2 times, most recently from 44c29cc to 92d9570 Nov 18, 2018

@lightningterror lightningterror force-pushed the lightning-fmvaspectratio-flatoutorigin branch from 92d9570 to 6abe797 Nov 18, 2018

@lightningterror lightningterror changed the title PCSX2: "FMV Aspect Ratio switch" feature PCSX2: "FMV Aspect Ratio Switch/Override" feature Nov 18, 2018

PCSX2: "FMV Aspect Ratio Switch/Override" feature.
Change "Switch to 4:3 aspect ratio when an FMV plays" to
"FMV Aspect Ratio Override" drop down menu.

The option temporarily changes the Aspect Ratio to either
16:9 or 4:3 depending on the option that is selected,
and depending on the Window Aspect ratio that is selected.

Original commit:
8d471e1

Co author: lightningterror.

@lightningterror lightningterror force-pushed the lightning-fmvaspectratio-flatoutorigin branch from 6abe797 to 0482f1d Nov 18, 2018

@lightningterror lightningterror merged commit fd7a862 into master Nov 18, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lightningterror lightningterror deleted the lightning-fmvaspectratio-flatoutorigin branch Nov 18, 2018

lightningterror added a commit that referenced this pull request Nov 18, 2018

PCSX2: Correct FMVAspectRatioSwitchNames ini labels.
Small follow up correction from #2690, the ini options were inverted.

samkatakouzinos added a commit to samkatakouzinos/pcsx2 that referenced this pull request Jan 6, 2019

PCSX2: Correct FMVAspectRatioSwitchNames ini labels.
Small follow up correction from PCSX2#2690, the ini options were inverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.