SPU2: Resample reverb input/output. #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ziemas
force-pushed
the
spu-reverb-resample
branch
from
74a4347
to
b0370e1
Compare
These filter coefficients come from mednafen, I think they were originally found by Neill Corlett. I have not personally verified their accuracy.
Using the same filter as the downsampling
Skip multiplying the 0's
Skip the 0 coefs here as well.
Ziemas
force-pushed
the
spu-reverb-resample
branch
from
b0370e1
to
f9afd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverb runs at half the the samplerate of the rest of the SPU so a change of samplerate is required. They way this is currently done is by decimating when downsampling and duplicating samples when upsampling without doing any filtering.
This adds proper filtering to this process, the filter coefficients are from mednafen but I think they were originally found by Neill Corlett.
I have not yet compared to real PS2 behavior and don't know when I'll get around to so I'm PR'ing this now.