COP0 PCCR: Don't update counters if counting is disabled #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of the spooky apparition in Grand Theft Auto 3 if you watch the intro. This is kind of just enabling the old code which was kind of correct, but the old code didn't ignore the time passed, so this also updates the last cycles.
|
Wow, quite a catch on that one, I will test to see if anything have changed in any of my games. |
|
Thanks :) yeah, didn't quite expect that one... |
|
I would imagine the game code of that game is hack-land to have such a problem. Btw, I see no difference in the games I tested. Might be worth checking the others GTA games to see what happens. |
|
My best guess is it's using performance counters to work out how long things are taking to load/unload, and because the timer is just running away, that it's thinking it's taken too long to happen, so instead of the game hanging doing that, they just leave it and continue? I'm not sure, very weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Gets rid of the spooky apparition in Grand Theft Auto 3 if you watch the intro.
This is kind of just enabling the old code which was kind of correct, but the old code didn't ignore the time passed, so this also updates the last cycles.
Rationale behind Changes
GTA 3 had a clone eightball if you watched the intro for some reason if you let the PCCR counters count when they are disabled.
Suggested Testing Steps
IDK, try games, i guess, Roland Garrett Tennis, Spongebob Bikini Bottom PAL and GTA 3 have been tested by me, but you're free to confirm.
Fixes #2714