Savestates: Small refactoring #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue: Ignore all these characters above to fix the issue. |
|
Make this optional |
MrCK1
force-pushed
the
savestate_reorg
branch
3 times, most recently
from
aa0c2e0
to
692871d
Compare
Unfortunately due to the changes required and the savestate version bump I will need to make, it will be difficult to make this a separate option. Is there a benefit you see to the old method of keeping everything in the same folder? |
MrCK1
force-pushed
the
savestate_reorg
branch
from
692871d
to
029b7b5
Compare
MrCK1
force-pushed
the
savestate_reorg
branch
from
029b7b5
to
d5f83be
Compare
MrCK1
changed the title
MrCK1
force-pushed
the
savestate_reorg
branch
2 times, most recently
from
e77c3d0
to
6dc06fc
Compare
MrCK1
force-pushed
the
savestate_reorg
branch
from
4cc38b2
to
ed473e0
Compare
github-actions
bot
added
Build | Project System
Counters
Debugger
Dependencies
github-actions
bot
removed
SPU2
Dependencies
MrCK1
force-pushed
the
savestate_reorg
branch
5 times, most recently
from
6ef4a9b
to
2de9e33
Compare
|
Tested:
Savestates work as expected in all of those above situations |
MrCK1
force-pushed
the
savestate_reorg
branch
from
2de9e33
to
a5fdbb8
Compare
Mrlinkwii
approved these changes
Nov 21, 2021
xTVaser
approved these changes
Nov 21, 2021
lightningterror
approved these changes
Nov 21, 2021
weirdbeardgame
added a commit
to weirdbeardgame/pcsx2
that referenced
this pull request
Mar 12, 2022
…gear solid that would not boot from path formatting issues
weirdbeardgame
added a commit
to weirdbeardgame/pcsx2
that referenced
this pull request
Mar 20, 2022
…gear solid that would not boot from path formatting issues
This was referenced Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Organized user-created savestates by saving into subfolders with game name and serial.
Detect PSX CRC properly, format console titlebar.
Fix bug with g_GameStarted and g_GameLoading not being reset on recompiler shutdown.
Fix bug with g_GameStarted and g_GameLoading not being set to proper status when loading savestate.
Rationale behind Changes
Cleaner directory for savestates, improve ease of saveestate management. Improve management of game state variables in regards to functionality.
Suggested testing steps
Save/load savestates, look for errors in directory/savestate creation or directory naming. Check for errors/crashes switching games.
Closes #4625, #4744