Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS: Revert be7e1163b4f7e3fe19876462fb26cd082ffb3ab4 #4891

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

lightningterror
Copy link
Contributor

Description of Changes

Reverts commit be7e116

Rationale behind Changes

Causes issues with many games, not worth it.

Suggested Testing Steps

Need testing #4087 #4836 #3373

Completely remove the code instead of commenting it out, seems to cause
issues with several games.
@refractionpcsx2
Copy link
Member

I have tested Chronicles of Narnia (actual game) and GS dumps for Kaan and Test Drive, all those issues appear to be fixed by this PR.

@tadanokojin
Copy link
Member

I was planning to look at this one of these days but if it's such a problem then I guess we can just revert it for now.

@tadanokojin tadanokojin merged commit 6ed0010 into master Oct 9, 2021
@tadanokojin tadanokojin deleted the clamp-optimization-remove branch October 9, 2021 01:56
refractionpcsx2 added a commit that referenced this pull request Oct 17, 2021
Fixes performance problems with Baldur's Gate 2
refractionpcsx2 added a commit that referenced this pull request Oct 17, 2021
Fixes performance problems with Baldur's Gate 2
@Squall-Leonhart
Copy link

Squall-Leonhart commented Nov 21, 2021

Significantly affected performance of Justice League Heroes on atleast the SSE4 build, refractions partial revert did not improve the situation.

As shown in #5036 the palette conversion partially helps to reclaim the performance but its a big loss considering prior to this revert the game ran at 100% without it and is as low as 6% after this change.

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Nov 21, 2021

Apparently it's already addressed with #4971

however the GS dump runs at 500fps for me on master.

@Squall-Leonhart
Copy link

Squall-Leonhart commented Nov 21, 2021

Oh!, for some reason i swear that PR looked like it was already included.

wait, nvm i'm mixing them up 4891 is in, 4971 is not

however the GS dump runs at 500fps for me on master.

AVX2 might not be affected, or its something weird with Pascal hardware that isn't present on Turing+

@refractionpcsx2
Copy link
Member

Yes one PR brung back texture region repeating, but this new one restores clamping and the other methods.

LibretroAdmin added a commit to libretro/pcsx2 that referenced this pull request Mar 30, 2023
LibretroAdmin added a commit to libretro/pcsx2 that referenced this pull request Mar 30, 2023
Fixes performance problems with Baldur's Gate 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants