-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS: Revert be7e1163b4f7e3fe19876462fb26cd082ffb3ab4 #4891
Conversation
Completely remove the code instead of commenting it out, seems to cause issues with several games.
I have tested Chronicles of Narnia (actual game) and GS dumps for Kaan and Test Drive, all those issues appear to be fixed by this PR. |
I was planning to look at this one of these days but if it's such a problem then I guess we can just revert it for now. |
Fixes performance problems with Baldur's Gate 2
Fixes performance problems with Baldur's Gate 2
Significantly affected performance of Justice League Heroes on atleast the SSE4 build, As shown in #5036 the palette conversion partially helps to reclaim the performance but its a big loss considering prior to this revert the game ran at 100% without it and is as low as 6% after this change. |
Apparently it's already addressed with #4971 however the GS dump runs at 500fps for me on master. |
Oh!, for some reason i swear that PR looked like it was already included. wait, nvm i'm mixing them up 4891 is in, 4971 is not
AVX2 might not be affected, or its something weird with Pascal hardware that isn't present on Turing+ |
Yes one PR brung back texture region repeating, but this new one restores clamping and the other methods. |
Fixes performance problems with Baldur's Gate 2
Description of Changes
Reverts commit be7e116
Rationale behind Changes
Causes issues with many games, not worth it.
Suggested Testing Steps
Need testing #4087 #4836 #3373