-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Clear missing files" option to recent ISO list #4975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
Maybe |
Or simply "Clear invalid ISO files". Maybe things could be made more obvious by referring to the entire ISO list (for the full removal, "Clean ISO list") and to the individual ISO files (for the pruning of only any missing ISO files, "Prune invalid ISO files"). |
Or an even more user friendly way of writing it |
Agree with the above. "Clear invalid ISO" to an end user could indicate something is wrong with your file itself, not that it's just been moved, whilst "clear missing files" directly states what the issue is. |
Agreed as well. |
My main suggestion would be to show a list of what's going to be removed on the confirmation dialog box, before you actually remove it. Otherwise, I could see times where you could accidentally remove all or most of the entries because of something not being mounted at the moment... |
Should be feasible to do something like this. |
I find it very useful. |
I agree. Will update the PR with a new commit soon. Is it still recommended to use the wx* functions and types wherever possible instead of STL? (ex. I know the style guide says to prefer wx but I keep hearing that there's a QT rewrite planned and was wondering if that means there's less of a focus now on using the existing wx code? |
On your location you can't fully avoid WX but if you can, sure. |
35fd078
to
cd6c119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits should be squashed and properly named with prefixes.
88220b7
to
5d5fdbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be tested.
Works properly, from what I can see. |
Description of Changes
Adds an option to the recent ISO list to remove all entries that can no longer be found in their original location.
Rationale behind Changes
Solution for #4963. I decided on using the term "prune" instead of "clean" because it sounds too similar to the existing "clear". Would welcome input on what the terminology for this function should be.
Suggested Testing Steps