-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameDB / Memcards - Replace yaml-cpp
with rapidyaml
#5099
Conversation
47e3cc8
to
0acacd7
Compare
common/StringUtil.cpp
Outdated
return Strncasecmp(str1.data(), str2.data(), str1.length()) == 0; | ||
} | ||
|
||
std::vector<std::string> convertMultiLineStringToVector(const std::string& multiLineString) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this called split
in pretty much every other language's stdlib?
pcsx2/GameDatabase.h
Outdated
std::string name = ""; | ||
std::string region = ""; | ||
Compatibility compat = Compatibility::Unknown; | ||
RoundMode eeRoundMode = RoundMode::Undefined; | ||
RoundMode vuRoundMode = RoundMode::Undefined; | ||
ClampMode eeClampMode = ClampMode::Undefined; | ||
ClampMode vuClampMode = ClampMode::Undefined; | ||
std::vector<GamefixId> gameFixes; | ||
std::vector<GamefixId> gameFixes = {}; | ||
std::vector<std::pair<SpeedhackId, int>> speedHacks; | ||
std::vector<std::string> memcardFilters; | ||
std::unordered_map<std::string, Patch> patches; | ||
std::vector<std::string> memcardFilters = {}; | ||
std::unordered_map<std::string, Patch> patches = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already the result of calling the default constructor. IMO it looks nicer to not have these.
acf643b
to
a3314d7
Compare
a3314d7
to
2e65575
Compare
Description of Changes
Rationale behind Changes
Suggested Testing Steps