Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS: More mipmapping fixes #5290

Merged
merged 7 commits into from
Jan 11, 2022
Merged

GS: More mipmapping fixes #5290

merged 7 commits into from
Jan 11, 2022

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Jan 9, 2022 •
edited
Loading

Description of Changes

More fixes to the mess that mipmapping is in the hardware renderers.

Suggested Testing Steps

Test Jak II, SOTC, other games which currently have issues.

@stenzek stenzek mentioned this pull request Jan 9, 2022
Closed
@stenzek stenzek mentioned this pull request Jan 9, 2022
Merged
@lightningterror
Copy link
Contributor

Trilinear doesn't seem to be working on dx11, ico godrays need forced trilinear and full mipmap.
ICO-godraysmissing-gs.zip

Here's a bonus one where trilinear breaks stuff (not a regression) if you want to make it better
cnr.zip

@TransparentBlue
Copy link

TransparentBlue commented Jan 10, 2022 •
edited
Loading

Affects #869 quite a bit.
Reintroduces flickering to some degree however fixes objects that layer multiple textures so that the layers properly combine and fade depending on distances and angle when trilinear ultra is forced whereas without this PR only a single layer is present and sometimes changes abruptly to another layer when moving even when trilinear ultra is forced.
Ape Escape 2 mimap issues.7z.zip

Never mind false positive caused by different settings.

@stenzek
Copy link
Contributor Author

stenzek commented Jan 10, 2022

Trilinear doesn't seem to be working on dx11, ico godrays need forced trilinear and full mipmap.
ICO-godraysmissing-gs.zip

Fixed.

@liamharper2453
Copy link

liamharper2453 commented Jan 10, 2022 •
edited
Loading

Can confirm assertion failure no longer occurs for Vulkan full mipmapping on [BUG]: Jak 2 [SLUS-97265]: issue with DX 11 and Vulkan renderers when mipmapping is used #5286.

Gets into gameplay ok now.

JordanTheToaster
JordanTheToaster approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@JordanTheToaster JordanTheToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trilinear works as expected in DX11.

lightningterror
lightningterror reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@lightningterror lightningterror left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above cnr dump doesn't look identical to opengl/vulkan when trilinear is used.
Looks more broken.

Anisotropic filtering seems broken with mipmapping on dx11
gsdx_20201107181218.zip

To elaborate on the aniso issue with mipmapping:
Before vulkan merge, aniso 16x, mipmap basic
image

Current master, same settings as above
image

PR, same settings as above
image

@lightningterror lightningterror merged commit cf2b6a8 into PCSX2:master Jan 11, 2022
@jeremybris jeremybris mentioned this pull request Jan 13, 2022
Closed
@stenzek stenzek deleted the more-mipmap-fixes branch April 15, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanTheToaster JordanTheToaster JordanTheToaster approved these changes

@lightningterror lightningterror lightningterror approved these changes

Assignees
No one assigned
Labels
GS: Direct3D 11 GS: Hardware GS: OpenGL GS: Vulkan GS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stenzek @lightningterror @TransparentBlue @liamharper2453 @JordanTheToaster