GS-hw: Apply clamp/wrap when FBMask enabled #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_fbmask16bit
branch
from
250ddd0
to
91acf29
Compare
refractionpcsx2
changed the title
refractionpcsx2
force-pushed
the
gs_fbmask16bit
branch
from
91acf29
to
ebdd996
Compare
refractionpcsx2
changed the title
lightningterror
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Make sure any clamps (but most importantly 16bit colour masking) gets applied when FBMask is used.
Rationale behind Changes
16 bit colours were incorrectly masked when FBMask was enabled, due to changes in #5471 it kind of made the problem rise to the surface and caused errors on Silent Hill 4, noticeable in the subway.
Suggested Testing Steps
Test games which use 16bit colours (you can usually tell because they use Dithering)