GS/HW: Regression fixes and GIF Fix for Puzzle Quest/Motocross Mania 3 #9773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
changed the title
Mrlinkwii
approved these changes
Aug 11, 2023
JordanTheToaster
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Stops it halfing the height on a shuffle by accident.
Fixes problem where it could try and read a null RT
Adjusted how GIF Intermittent packets split.
Rationale behind Changes
Was too horny with the halving, so in some cases the actual size got halved, not just the doubled shuffle size.
Regression from #9745
null RT was possible if there was no RT but it was still reading a texture, possibly in an Alpha tested Z write situation.
Adjusted GIF intermittent packet timing to be a bit kinder to games without sacrificing speed.
Suggested Testing Steps
Test Onimusha 3, Wallace & Gromit Project Zoo, Puzzle Quest, Motocross Mania 3. Make sure nothing is broken.
Fixes #6733 Puzzle Quest flickering graphics
Fixes Motocross Mania 3 flickering textures
Fixes Onimusha 3 bad height on shuffle, plus some invisible bad height changes in Haunting Ground and Sniper Elite.
Onimusha 3:
Master:
PR:
Motocross Mania 3:
Master:
PR:
Puzzle Quest:
Master:
PR: