Add EptReader for Entwine Point Tile data #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobu
approved these changes
Sep 14, 2018
abellgithub
reviewed
Sep 17, 2018
abellgithub
reviewed
Sep 17, 2018
- Explicitly handle unexpected JSON values. - Thread count specification and note about the 4-thread minimum in the doc. - Remove spurious try-catch around SRS handling. - Absolute-value around scaling math. - Use Utils::remove, remove confusing default argument, and initialize values in ready().
|
Yes, the thread pool code was copied from Entwine. The i3s driver will also be using it (right now on that branch it uses its own copy) so I agree with hoisting it somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reader for the Entwine Point Tile format, supporting spatially accelerated bounds/tile queries and both laszip and binary EPT data-types.