Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared GitHub Actions #12

Merged
merged 6 commits into from
Oct 31, 2021
Merged

Use shared GitHub Actions #12

merged 6 commits into from
Oct 31, 2021

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Sep 22, 2021

Uses the shared actions introduced by PDLPorters/devops#8.

@zmughal zmughal force-pushed the gha-shared-actions branch 4 times, most recently from 10dcec7 to 46251e5 Compare October 27, 2021 03:10
Uses the shared actions introduced by <PDLPorters/devops#8>.
Clang 12.0.0 segfaults on macos-10.
This is due to linking issues in the test phase when the library is
under `blib/`. This may be fixed by setting `rpath` or using static
linking.
@zmughal zmughal marked this pull request as ready for review October 30, 2021 22:06
@zmughal zmughal requested a review from mohawk2 October 31, 2021 02:54
Copy link
Member

@mohawk2 mohawk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mohawk2 mohawk2 merged commit 1d20d0d into master Oct 31, 2021
@mohawk2 mohawk2 deleted the gha-shared-actions branch October 31, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants