Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same docker image versions for tests #61

Closed
Steveb-p opened this issue Apr 21, 2019 · 7 comments · Fixed by #62
Closed

Use same docker image versions for tests #61

Steveb-p opened this issue Apr 21, 2019 · 7 comments · Fixed by #62

Comments

@Steveb-p
Copy link
Contributor

Steveb-p commented Apr 21, 2019

I'm sitting here with a very, very bad internet connection and without docker images preloaded on my laptop (I'm using a different one that usually) and I've noticed that there are two different versions of MongoDB service being pulled - one 3.4 and second 3.4.0. The same goes for alpine, but considering it's a lot smaller...

Anyway, I think we should use the same images in all tests?

EDIT: Also preferably we could use smaller "service" image instead of Mongo? Like nginx:alpine? (150 MB~ish worth of docker layers would become around 7 MB?)

@AlexZeitler
Copy link
Contributor

AlexZeitler commented Apr 21, 2019

As can be seen in #45 3.4 broke the tests.
Using nginx:alpine would be fine but we need to make the start blocking then.

@Steveb-p
Copy link
Contributor Author

I'd say we should pin to a specific version anyway to prevent such random test failures :)

Assertion in the test in question can also be "rephrased" to check for something else than OS name :) It is a test of docker-compose exec anyway :)

@AlexZeitler
Copy link
Contributor

👍

@AlexZeitler
Copy link
Contributor

The entry for nginx:alpine in docker-compose should contain this to be blocking:

command: nginx -g "daemon off"

@Steveb-p
Copy link
Contributor Author

@AlexZeitler I'll provide PR in the evening. Had a few days off due to holidays & being busy at work.

@AlexZeitler
Copy link
Contributor

👍 Take your time

Steveb-p added a commit to Steveb-p/docker-compose that referenced this issue Apr 28, 2019
@Steveb-p
Copy link
Contributor Author

Intentionally left Nginx with Debian as OS for your checkOS tests.

Also, is there any particular reason for tape as test framework? I'm not really familiar with it, but it doesn't seem to be "vocal" about which tests exactly did not pass and it's kinda a hurdle to look through output to see :) Not to mention not really being able to filter tests to only run those I'm interested in (I didn't really look too much into it, just curious).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants