-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same docker image versions for tests #61
Comments
As can be seen in #45 3.4 broke the tests. |
I'd say we should pin to a specific version anyway to prevent such random test failures :) Assertion in the test in question can also be "rephrased" to check for something else than OS name :) It is a test of |
👍 |
The entry for
|
@AlexZeitler I'll provide PR in the evening. Had a few days off due to holidays & being busy at work. |
👍 Take your time |
Intentionally left Nginx with Debian as OS for your Also, is there any particular reason for |
I'm sitting here with a very, very bad internet connection and without docker images preloaded on my laptop (I'm using a different one that usually) and I've noticed that there are two different versions of MongoDB service being pulled - one
3.4
and second3.4.0
. The same goes for alpine, but considering it's a lot smaller...Anyway, I think we should use the same images in all tests?
EDIT: Also preferably we could use smaller "service" image instead of Mongo? Like nginx:alpine? (150 MB~ish worth of docker layers would become around 7 MB?)
The text was updated successfully, but these errors were encountered: