Skip to content
This repository has been archived by the owner on Jul 4, 2020. It is now read-only.

Updated hanging entities listener #69

Merged
merged 1 commit into from
Jun 15, 2013
Merged

Updated hanging entities listener #69

merged 1 commit into from
Jun 15, 2013

Conversation

socram8888
Copy link
Contributor

Fixes #58: block item frame placement and removal

@zml2008
Copy link
Member

zml2008 commented Jun 6, 2013

Uh, why'd you increment the version?

Sent from Mailbox for iPhone

On Thu, Jun 6, 2013 at 8:18 AM, Marcos Vives Del Sol
notifications@github.com wrote:

Fixes #58: block item frame placement and removal
You can merge this Pull Request by running:
git pull https://github.com/socram8888/Modifyworld master
Or you can view, comment on it, or merge it online at:
#69
-- Commit Summary --

@socram8888
Copy link
Contributor Author

Well, 1.19.5 is the current PEX version.

@zml2008
Copy link
Member

zml2008 commented Jun 8, 2013

ah. I guess we forgot to bump the version when releasing. I'll fix that,
but it should be a separate commit rather than in this pull request.

On Thu, Jun 6, 2013 at 9:02 AM, Marcos Vives Del Sol <
notifications@github.com> wrote:

Well, 1.19.5 is the current version.


Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-19055571
.

@zml2008
Copy link
Member

zml2008 commented Jun 15, 2013

I've updated the version. Update your PR to only change hanging and
I'll merge it.

On Fr, Jun 7, 2013 at 5:16 , Zach L zach@zachsthings.com wrote:

ah. I guess we forgot to bump the version when releasing. I'll fix
that, but it should be a separate commit rather than in this pull
request.

On Thu, Jun 6, 2013 at 9:02 AM, Marcos Vives Del Sol
notifications@github.com wrote:

Well, 1.19.5 is the current version.


Reply to this email directly or view it on GitHub.

@socram8888
Copy link
Contributor Author

It is not compiling against your current version. You've forgot to update the Bukkit version in pom.xml, as in 1.3.1 there were no item frames and package org.bukkit.event.hanging did not exist.

@zml2008
Copy link
Member

zml2008 commented Jun 15, 2013

Then update the Bukkit version. Just not the version of MW itself.

On Sat, Jun 15, 2013 at 2:36 AM, Marcos Vives Del Sol <
notifications@github.com> wrote:

It is not compiling against your current version. You've forgot to update
the Bukkit version in pom.xml, as in 1.3.1 there were no item frames and
package org.bukkit.event.hanging did not exist.


Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-19493866
.

@socram8888
Copy link
Contributor Author

Done

zml2008 pushed a commit that referenced this pull request Jun 15, 2013
Updated hanging entities listener
@zml2008 zml2008 merged commit 45661e2 into PEXPlugins:master Jun 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ItemFrames & Command_block
2 participants