Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.0.0a13 #95

Merged
merged 29 commits into from
Apr 5, 2019
Merged

Release 0.0.0a13 #95

merged 29 commits into from
Apr 5, 2019

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 5, 2019

PEtab format updates:

  • Add description of visualization table
  • Cleanup

Python package updates:

  • Add visualization functions
  • Add support for condition-specific dynamic parameters

Dantong Wang and others added 28 commits January 9, 2019 10:54
we can still discuss about it :)
[WIP] Data visualization functions
#92)

* Allow for condition-specific overrides of dynamic parameters (Closes #90)

- Remove duplicate functions
- Remove non-standard handling of constant parameters
- Replace fixed parameter names by nominal values during mapping
- Check override parameter scale where possible

* Apply suggestions from code review
* Filter out assignmentrule targets
* doc
#94)

* Add support for non-constant parameter overrides in condition table for parameter_df creation
@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #95 into master will increase coverage by 3.77%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   53.74%   57.51%   +3.77%     
==========================================
  Files           6        7       +1     
  Lines         694      758      +64     
  Branches      147      167      +20     
==========================================
+ Hits          373      436      +63     
  Misses        293      293              
- Partials       28       29       +1
Impacted Files Coverage Δ
petab/lint.py 41.87% <0%> (-0.21%) ⬇️
petab/__init__.py 100% <100%> (ø) ⬆️
petab/version.py 100% <100%> (ø) ⬆️
petab/core.py 74.7% <80.85%> (+3.73%) ⬆️
petab/generate_experiment_id.py 87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e304e9...8791d10. Read the comment docs.

@dweindl dweindl merged commit e9aeecf into master Apr 5, 2019
@dweindl dweindl deleted the release_0.0.0a13 branch April 5, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants