Add support for non-constant parameter overrides in condition table f… #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or parameter_df creation
Codecov Report
@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
+ Coverage 57.39% 57.51% +0.12%
===========================================
Files 7 7
Lines 751 758 +7
Branches 165 167 +2
===========================================
+ Hits 431 436 +5
- Misses 291 293 +2
Partials 29 29
Continue to review full report at Codecov.
|
yannikschaelte
approved these changes
Apr 4, 2019
| condition_parameters = list( | ||
| set(condition_df.columns.values.tolist()) - {'conditionId', | ||
| 'conditionName'}) | ||
| for overridee in condition_parameters: |
There was a problem hiding this comment.
kinda hard to read. can you add some docs?
There was a problem hiding this comment.
Hm. Line 910? Which part do you mean?
There was a problem hiding this comment.
in particular what this invert stuff does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or parameter_df creation (#94)