Update dynamic filters immediately on sneak #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, it seems like you did not sign off your commit though, which is required for this repo. Are you able to correct that? |
Oh sorry, I had heard this was no longer required. Last time I tried to set that up I ran into some issues but I'll give it another go. Edit: I think I have signed it now, let me know if I didn't do it right. |
OhPointFive
force-pushed
the
handle-crouching-immediately
branch
from
f3aa5ec
to
41c3857
Compare
Previously, dynamic filters based on crouching would only update if the player moved an entire block. Now, dynamic filters fire immediately when the player crouches. Signed-off-by: OhPointFive <ohpointfive@gmail.com>
OhPointFive
force-pushed
the
handle-crouching-immediately
branch
from
41c3857
to
5f74bbe
Compare
Pablete1234
approved these changes
Jul 5, 2022
Electroid
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you sneak, dynamic filters don't update when players sneak immediately — only after they've moved a block. Dynamic filters happening immediately when you press shift may be desirable — perhaps a glass spawn platform where players can press shift to activate a portal to drop down where they want.
This PR makes it so that when a player presses shift, dynamic filters are updated immediately.