Fix fluid damage values for BlockFromToEvents #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhPointFive
force-pushed
the
fix-water-id
branch
from
4942495
to
0de33f0
Compare
For some reason, SportPaper (and presumably other papers) use the wrong damage values in the BlockFromToEvents, using the damage value of the originating block instead of the one formed as a result. This manually calculates the damage value of the block that would be formed, and updates the event. Signed-off-by: OhPointFive <ohpointfive@gmail.com>
Signed-off-by: OhPointFive <ohpointfive@gmail.com>
OhPointFive
force-pushed
the
fix-water-id
branch
from
0de33f0
to
020d3c4
Compare
Pablete1234
approved these changes
Jul 15, 2022
Electroid
approved these changes
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, SportPaper (and presumably other papers) use the wrong damage values in the
BlockFromToEvents, using the damage value of the originating block instead of the one formed as a result.This makes it difficult to, for example, make water flow only 3 blocks through a filter, since it'll hang weirdly over edges or stop working entirely sometimes.
We could patch it in sportpaper (although I think it was difficult to do, when I checked) but I suspect other Papers have the same bug, so it's easier to handle it here, instead.
This PR fixes the damage value of these events, so flowing water can be correctly filtered.