Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spread-teammates for spawns #1032

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

calcastor
Copy link
Contributor

@calcastor calcastor commented Jul 13, 2022

There are some map concepts where to ability to set spread="true" for team spawns is desirable. This PR permits that functionality as a separate attribute titled spread-teammates.

Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior is working as intended, ie: spread=true means to not spawn you close to enemy players.

If you're looking for also not spawning you close to teammates, you need another xml property (defaulting to original behavior).

Maybe something like spread-teammates=true/false (default to false, which is original behavior)

@calcastor calcastor marked this pull request as draft July 18, 2022 04:54
Signed-off-by: BT (calcastor/mame) <43831917+calcastor@users.noreply.github.com>
@calcastor calcastor changed the title Allow spread="true" for team spawns Implement spread-teammates for spawns Jul 21, 2022
@calcastor calcastor marked this pull request as ready for review July 21, 2022 20:29
@Electroid Electroid merged commit 979a893 into PGMDev:dev Jul 22, 2022
@calcastor calcastor deleted the spread-team-spawns branch July 24, 2022 19:16
@calcastor calcastor restored the spread-team-spawns branch July 24, 2022 19:16
@calcastor calcastor deleted the spread-team-spawns branch July 24, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants