Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter a required property of dynamic kits #1085

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

Pugzy
Copy link
Contributor

@Pugzy Pugzy commented Oct 20, 2022

Update the dynamic kit definition to require a filter property.
This is currently "optional" but the map will break if not defined. Whoops.

The below error message will now be shown when not provided or when provided as a non-dynamic filter.

image

Signed-off-by: Pugzy pugzy@mail.com

Signed-off-by: Pugzy <pugzy@mail.com>
@Pugzy Pugzy requested a review from Electroid as a code owner October 20, 2022 08:26
@Electroid Electroid merged commit 57e4269 into PGMDev:dev Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants