Cleanup cloud command graph & add player parser #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
force-pushed
the
cloud-cleanup
branch
2 times, most recently
from
5fc5f8e
to
aab04bf
Compare
Signed-off-by: Pablo Herrera <pabloherrerapalacio@gmail.com>
Pablete1234
force-pushed
the
cloud-cleanup
branch
from
aab04bf
to
2192112
Compare
Electroid
approved these changes
Jan 29, 2023
|
Looks good to merge, but seems to have some build failures. |
|
It's related to a cloud library change, i've updated to 1.8.1 to fix a bug, and that version is only existing on our repo ATM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts pgm-specific logic from CommandGraph into PGMCommandGraph, so that the class can be re-used easier by other plugins, and also adds a Player parser for any command that is leftover using player and not match player