Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filters in blitz #744

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Implement filters in blitz #744

merged 1 commit into from
Dec 18, 2020

Conversation

Pablete1234
Copy link
Member

@Pablete1234 Pablete1234 commented Dec 18, 2020

Fixes #365

Adds a filter attribute or child to blitz, if the filter denies, your life counter does not go down.

Example, you will only lose a life when dying after 30s from match start:

<blitz>
  <lives>5</lives>
  <filter>
    <time>30s</time>
  </filter>
</blitz>

Adding it as an attribute is also valid (note, the filter will have to be defined elsewhere):

<blitz filter="time-30-sec">
  <lives>5</lives>
</blitz>

@Pablete1234 Pablete1234 added the feature New feature or request label Dec 18, 2020
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Copy link
Member

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@Electroid Electroid marked this pull request as ready for review December 18, 2020 12:32
@Electroid Electroid merged commit 6de5651 into dev Dec 18, 2020
@Electroid Electroid deleted the blitz-filter branch December 18, 2020 12:34
@Pablete1234
Copy link
Member Author

This was a draft because i have done 0 testing on this feature so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

Successfully merging this pull request may close these issues.

Filters and show attribute for Blitz module
2 participants