-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "team-color" attribute to Armor Kits #856
Conversation
I don't really see what is the issue here that this resolves, a colour picker is easy to find and search online while referring to the documentation in another tab while writing XML. Since they are hex colours, what would be the default values you would use for the team colours? |
It's simply convenience, also removes the need of having 3 kits, one main one and one per each team that have the other as parent, it simplifies XML |
Did the Stratus (or was it Walrus) implementation work with blocks too (glass, clay, wool etc)? I recall some funky repair integration too. Anyone got a link to their docs? |
Since this is syntax sugar, it'd be nice to make it even simpler: |
color is parsed under |
Signed-off-by: destial <destialpvp@gmail.com>
Signed-off-by: destial <destialpvp@gmail.com>
Signed-off-by: destial <destialpvp@gmail.com>
Signed-off-by: destial <destialpvp@gmail.com>
Signed-off-by: destial <destialpvp@gmail.com>
Signed-off-by: destial <destialpvp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, I think the syntax you've proposed is good.
Congrats on your first PGM feature! (and one of the most requested ones by map makers!) |
When ever I create maps, most of the time I have to create a separate kit for the teams while trying to find the correct color that corresponds to their color.
Like so:
So, I added an attribute that automatically uses the team's color so that I can just use the default kit and it will automatically use the team's color when applied.
Like so:
I made it so "team-color" overrides the "color" attribute since it is applied during the match and not beforehand.