Throttle tablist based on tps & match cycle #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Electroid
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tablist throttling based on tps (if server is running at 19.5tps, tablist won't render more often than once every 500ms, at 19.0tps, more than once every second, etc), as well as completely throttling (the max delay of one render per 5 seconds) while the a match transfer is going on (players are being moved from match A to match B).
This should help with the lag on high playercounts on cycle, where tablist re-renders so many times, and the tablist render time is not necessarily impacted but many packets get queued up and take up to 30s to get dispatched, making everyone feel very laggy.
This has been tested and works correctly.